"Save all and commit" dialog should stage before committing #69240
Description
Issue Type: Bug
- Open or create a project that uses Git source control.
- Create or change some files and stage those changes.
- Change a file without saving it.
- Try to make a commit.
This will bring up a dialog asking how to make the commit, which includes options to cancel, commit, or save all and commit.
The nature of the dialog suggests that the file will be included in the commit when you save, which is true if you have no staged files. But when you have staged files, the newly-saved files should be staged as well in order to be included in the commit.
Expected behavior: Files saved with this dialog should be staged for inclusion in the commit.
Actual behavior: The commit is made without staging changes in the file.
VS Code version: Code 1.31.1 (1b8e830, 2019-02-12T02:20:54.427Z)
OS version: Windows_NT x64 10.0.17763
System Info
| Item | Value |
|---|---|
| CPUs | Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz (4 x 3192) |
| GPU Status | 2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled |
| Memory (System) | 15.89GB (6.66GB free) |
| Process Argv | |
| Screen Reader | no |
| VM | 0% |
Extensions (3)
| Extension | Author (truncated) | Version |
|---|---|---|
| EditorConfig | Edi | 0.13.0 |
| tslint | eg2 | 1.0.43 |
| prettier-vscode | esb | 1.8.1 |