-
Notifications
You must be signed in to change notification settings - Fork 38.2k
Closed
Labels
debtCode quality issuesCode quality issuesengineeringVS Code - Build / issue tracking / etc.VS Code - Build / issue tracking / etc.
Description
We have changed our compile to emit ES6 JavaScript, instead of ES5. That means let or const don't become var etc, it also means that classes are emitted as classes, not as functions.
There are extensions that emit ES5 JavaScript and that extend from our API types. The code usually looks like this:
var PathCompletionItem = (function (_super) {
__extends(PathCompletionItem, _super);
function PathCompletionItem(filename, isfile) {
_super.call(this, filename);
this.foo = 1;
}
PathCompletionItem.prototype.bar = function () {
this.foo += 1;
};
return PathCompletionItem;
}(vscode.CompletionItem));The challenge is that calling a class-constructor from a function extending it, isn't possible and requires a workaround. We have the es5ClassCompat-util for that. However, there are only eight extensions that use this pattern and this issue track the migration to emitting ES6 code.
- https://github.com/vscode-contrib/vscode-versionlens/issues/132
- Migration: please emit ES6 output pmneo/ts-importer#51
- Migration: please emit ES6 output iann0036/cloud9-sync#16
- Migration: please emit ES6 output xiaogangya/markdown-authoring#6
- Migration: please emit ES6 output LambdaFactory/Neptune-public#25
- Migration: please emit ES6 output bbenoist/vscode-quicktips#1
- https://marketplace.visualstudio.com/items?itemName=QuantumSheep.now-vscode (GH link broken)
- Migration: please emit ES6 output JeisonJHA/vscode-shortcut#1
- Migration: please emit ES6 output vshaxe/vshaxe#317
Calling static functions using the new keyword (see #69533)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
debtCode quality issuesCode quality issuesengineeringVS Code - Build / issue tracking / etc.VS Code - Build / issue tracking / etc.