Skip to content

Broken fuzzy search highlighting/ranking for trimable strings #62918

@fabiospampinato

Description

@fabiospampinato
  • VSCode Version: 1.28.2
  • OS Version: macOS 10.13.5

Fuzzy messy (#34088) search gives wrong highlights and inconsistent rankings when the quickpick entries start with some whitespace characters.

In the following GIF I'll be making two searches, in the first one the entries start with whitespace characters, in the second one they don't, there are some issues:

  1. in the first search the wrong characters are highlighted. Notice also how removing the hyphen in vscode-todo causes the highlighted characters to go from vscode-todo to vsc and ode- for the vscode-todo-plus entry, this isn't happening if the entries don't start with whitespace characters.

  2. In the second search you can see how removing the hyphen from vscode-todo leads to different rankings. And that hyphens obviously shouldn't matter since all entries have it in the same exact position.

kapture 2018-11-11 at 14 24 25

IMHO the root cause of this is that for some reason proper fuzzy search is still not available everywhere, instead it looks like there are lots of special cases for supposedly improving the ranking. Shouldn't this be fixed sooner rather than later?

Metadata

Metadata

Assignees

Labels

*duplicateIssue identified as a duplicate of another issue(s)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions