Skip to content

launch.json envFile not escaped before injecting #61902

@itslenny

Description

@itslenny
  • VSCode Version: Version 1.28.2 (1.28.2)
  • OS Version: OSX 10.14

Steps to Reproduce:

  1. add "envFile": "${workspaceRoot}/.env" to launch.json
  2. add value to .env that contains ! characters
my_secret=SomeAwesomeSecret!!!

Does this issue occur when all extensions are disabled?: Yes

Because ! is previous command in bash when it loads the .env file it fails catastrophically. These characters (and probably others) should be escaped when .env is loaded or perhaps it should be loaded in a way that doesn't try to execute things like that.

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugdebugDebug viewlet, configurations, breakpoints, adapter issuesverification-neededVerification of issue is requestedverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions