Skip to content

layout trashing in WorkbenchLayout#layout #60031

@jrieken

Description

@jrieken
  • record performance and reload
  • (expensive) layout trashing happens WorkbenchLayout#layout

screenshot 2018-10-05 at 17 10 21

I fiddled with this and it seems to be caused by these lines https://github.com/Microsoft/vscode/blob/2f28e6ba8ae02a51d20e2c85fd8cd702fc8de37e/src/vs/workbench/browser/layout.ts#L547-L554

Question are

  • this looks like a workaround for something. is that still needed?
  • is there a better way to achieve the workaround, e.g. not having it during the main layout call?

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions