Skip to content

Regression: editorService doesn't open http/https schema URLs as of 1.25 #58924

@BoykoAlex

Description

@BoykoAlex
  • VSCode Version: 1.25 and up
  • OS Version: OSX, but should be reproducible on Win and Linux

A block of code has been removed:

		// Support opening foreign resources (such as a http link that points outside of the workbench)
		const resourceInput = <IResourceInput>input;
		if (resourceInput.resource instanceof URI) {
			const schema = resourceInput.resource.scheme;
			if (schema === Schemas.http || schema === Schemas.https) {
				window.open(resourceInput.resource.toString(true));

				return TPromise.wrap<IEditor>(null);
			}
		}

it used to be in the WorkbenchEditorService under editor/commons. Now it seems to be moved under editor/browser and class is EditorService

Here is the commit that introduced the regression: ef92f85#diff-7260c109d203125646107c652086f25c

Our VSCode extension was relying on this behaviour to open URL in the browser for a workspace symbol with Location uri property being an http/https schema URL.

Are there any workarounds?
If not any chance this code can be put back or moved in here for example? https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/quickopen.ts#L276

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugverifiedVerification succeeded

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions