Skip to content

TypeScript refactorprovider provider uses activeTextEditor's selection #49060

@srivatsn

Description

@srivatsn

The refactor provider for TypeScript uses the activeTextEditor's selection(https://github.com/Microsoft/vscode/blob/master/extensions/typescript-language-features/src/features/refactorProvider.ts#L131) to get the range instead of using the range that's passed in. This is problematic if the provider is invoked via an API. For eg, in a LiveShare guest session if the guest makes a selection, we would only get refactorings for the host's selection.

/cc @jrieken @kieferrm

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions