-
Notifications
You must be signed in to change notification settings - Fork 38.9k
Unsafe canHandleResource usages #48275
Copy link
Copy link
Closed
Labels
debtCode quality issuesCode quality issuesremoteRemote system operations issuesRemote system operations issues
Milestone
Description
We have RemoteFileService#canHandleResource which was introduced as workaround to be able to restore editors from providers that aren't known (yet) but that were around during the last session: https://github.com//Microsoft/vscode/commit/a23633b5d42dc486a668e49a232957696750c254.
This wasn't designed to be a general purpose API and I am surprised by its popularity. In hindsight the FileEditorInput should have serialised that knowledge about other-schemes and not the file service. I want to make that change but many other references leave me puzzled. This is what's to do
- use
canHandleResourcein combination withonDidChangeFileSystemProviderRegistrations - don't rely on this information statically, e.g. expect that scheme come and do and expect that in the beginning there is just the
file-scheme
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
debtCode quality issuesCode quality issuesremoteRemote system operations issuesRemote system operations issues