Skip to content

Icons for TreeViewItems fallbacking to default folder item if file uri is used.  #43216

@Krzysztof-Cieslak

Description

@Krzysztof-Cieslak

Example:
image 1

As far as I understand this line is a problem - https://github.com/Microsoft/vscode/blob/5755810a58ac76ffedb037647f1cd6fec406efe9/src/vs/workbench/browser/parts/views/treeView.ts#L334

If an item has Expended or Collapsed state (which basically means it's an item with childs) then we expect folder icon.

In general, I don't think we should have such convention at all, and consumers should be able to set any icon they want - in case of my extension, tree view shows some information from the file, so it makes sense for me to use file icon on the node with child elements.

CC: @sandy081

Metadata

Metadata

Assignees

Labels

apibugIssue identified by VS Code Team member as probable bugtree-viewsExtension tree view issuesverification-neededVerification of issue is requestedverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions