Skip to content

Terminal panel automatically maximized #41625

@etchone

Description

@etchone
  • VSCode Version: Code 1.19.2 (490ef76, 2018-01-10T15:55:03.538Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions:
Extension Author (truncated) Version
code-gnu-global aus 0.2.2
vscode-clang mit 0.2.2
cpptools ms- 0.14.5

Description:
The terminal panel automatically maximized when I resize the window.

I think this was caused by the method of maximizing this panel. Maybe it was like this:

if(window.height - panel.height > MAX_PANEL_HEIGHT)
    enablePanelMaximize();
else /*...*/;

And when I resize the window to be less high, the condition is reached because I only changed the window's height, didn't change the panel's.

Although this is not a serious problem, I still feel annoyed as I should use my mouse to click the button each time I do so.

Hope you can fix this 😄


Steps to Reproduce:

  1. Open an empty window, no folder open needed
  2. Open the powershell terminal, and make it longer(x-axis)
  3. Put the window on a top corner, either left-top or right-top(You can drag it there using mouse or using keyboard Win+Right,Win+Up)
    By now, you can see the maximize button has changed

Reproduces without extensions: Yes

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bughelp wantedIssues identified as good community contribution opportunitieslayoutGeneral VS Code workbench layout issuesverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions