Skip to content

Show tab shrinking overflow differently (no "...", shadow?) #39417

@Tekbr

Description

@Tekbr
  • VSCode Version: 1.19.0-insider (5b0fa2e Date 2017-12-01T06:14:38.596Z )
  • OS Version: Windows 10

-- Sorry for the English, I used Google Translator --

As he talked to @bpasero , he asked to be tracked in a new case. From #15048

Comment @Tekbr #15048

@bpasero An idea ... Instead of using the '...', why not use the style of Microsoft Edge, Mozilla Firefox and Google Chrome? 😉 The text is below the "X" (erased slightly) as the guide decreases.

tab

Particularly, I prefer the style of Firefox.

Comment @bpasero #15048

@Tekbr good suggestions. I am not a big fan of how Edge is simply clipping the text at the end of the tab. I really like what Firefox/Chrome are doing with the fading out in the end, if anyone wants to chime in with a reasonable PR (not too crazy, just CSS), feel free.

What I can change though is to not leave the room for the close button. I realized that when shrinking is enabled, the close button should only show up on hover, but otherwise not consume any space:

33417693-cc896aec-d5a2-11e7-93aa-f6f2b9a33923

Comment @Tekbr #15048

@bpasero Thanks for the feedback!!

I was happy with your move !! 😄 👏 👏

By your comment it seems like something simple to do (or not) 🤔 , but after going through the team tests .. or even before (if you think better) maybe crawl for a new case suggesting for beginners, no? Referring to this case and the test case, with my comment and your comment (if you think you should). That way, someone can locate it more easily! 🤔

Anyway, thanks again for the feedback! 👍

Comment @bpasero #15048

Sure, feel free to create a new issue for it and we can ask for help.

@bpasero If necessary, update the case. Make the necessary modifications / simplifications. (do it please.)

Reproduces without extensions: Yes

Metadata

Metadata

Assignees

Labels

feature-requestRequest for new features or functionalityhelp wantedIssues identified as good community contribution opportunitiesverification-neededVerification of issue is requestedverifiedVerification succeededworkbench-tabsVS Code editor tab issues

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions