-
Notifications
You must be signed in to change notification settings - Fork 38.2k
Closed
Labels
Description
Extracted from #37541:
@jrieken now that we have the startup phases in lifecycle service, should we change registerWorkbenchContribution to accept an optional phase argument and then when we instantiate the contributions respect that event to delay the instantiation?
Yeah, the registry should be per-phase and we should revisit each contribution and decide in which phase it should get created. Maybe even add another phase like RunningForABit so dust can settle..
This would need to be wired into the setInstantiationService call of the BaseRegistry I guess.
Unsure... Not even sure what that is but feels we leak a layer to low. I would suggest to have an instance of those per phase and hide the idea of phases from it
Reactions are currently unavailable