Skip to content

Funky wording for code action #33511

New issue
New issue
Closed
Closed
Funky wording for code action#33511
Assignees
mjbvz
Labels
javascriptJavaScript support issuestypescriptTypescript support issuesupstreamIssue identified as 'upstream' component related (exists outside of VS Code)

Description

@jrieken
Johannes Rieken (jrieken)
opened on Aug 30, 2017

re #33282

  • have code like this const six = 1 + 2 + 3;
  • be on one of the numbers
  • the code actions reads "extract function into global scope" which is misleading because I am not on a function, I'd prefer "extract as function..."

screen shot 2017-08-30 at 14 22 04

Activity

  1. Johannes Rieken (jrieken)
    assigned
    Matt Bierner (mjbvz)
    on Aug 30, 2017
  2. Johannes Rieken (jrieken)
    changed the title [-]Funky working for code action[/-] [+]Funky wording for code action[/+] on Aug 30, 2017
  3. Matt Bierner (mjbvz)
    added
    upstreamIssue identified as 'upstream' component related (exists outside of VS Code)
    javascriptJavaScript support issues
    typescriptTypescript support issues
    on Aug 31, 2017

  4. mjbvz commented on Aug 31, 2017

    @mjbvz
    Matt Bierner (mjbvz)
    on Aug 31, 2017
    Contributor

    Agreed. I've opened microsoft/TypeScript#18176 to discuss this with TypeScript

    Closing as upstream

  5. Matt Bierner (mjbvz)
    closed this as completedon Aug 31, 2017
  6. vscodebot
    locked and limited conversation to collaborators on Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

javascriptJavaScript support issuestypescriptTypescript support issuesupstreamIssue identified as 'upstream' component related (exists outside of VS Code)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions