Skip to content

Timeline view leaks event listeners #241536

@rzhao271

Description

@rzhao271

On OSS:

  1. Open a workspace.
  2. Open the Timeline view.
  3. Open different files one at a time in the editor so the Timeline view refreshes.
  4. 🐛 The Timeline view leaks event listeners.
[30656:0221/145939.131:INFO:CONSOLE(23)] "[LEAKED DISPOSABLE] Error: CREATED via:
    at GCBasedDisposableTracker.trackDisposable (vscode-file://vscode-app/c:/Users/raymondzhao/work/vscode/out/vs/base/common/lifecycle.js:27:23)
    at trackDisposable (vscode-file://vscode-app/c:/Users/raymondzhao/work/vscode/out/vs/base/common/lifecycle.js:198:24)
    at toDisposable (vscode-file://vscode-app/c:/Users/raymondzhao/work/vscode/out/vs/base/common/lifecycle.js:276:18)
    at MutableToken._event (vscode-file://vscode-app/c:/Users/raymondzhao/work/vscode/out/vs/base/common/event.js:876:28)
    at TimelinePane.loadTimelineForSource (vscode-file://vscode-app/c:/Users/raymondzhao/work/vscode/out/vs/workbench/contrib/timeline/browser/timelinePane.js:481:35)
    at TimelinePane.loadTimeline (vscode-file://vscode-app/c:/Users/raymondzhao/work/vscode/out/vs/workbench/contrib/timeline/browser/timelinePane.js:425:36)
    at TimelinePane.setUriCore (vscode-file://vscode-app/c:/Users/raymondzhao/work/vscode/out/vs/workbench/contrib/timeline/browser/timelinePane.js:268:14)
    at TimelinePane.onActiveEditorChanged (vscode-file://vscode-app/c:/Users/raymondzhao/work/vscode/out/vs/workbench/contrib/timeline/browser/timelinePane.js:314:14)
    at Emitter._deliver (vscode-file://vscode-app/c:/Users/raymondzhao/work/vscode/out/vs/base/common/event.js:939:22)
    at Emitter._deliverQueue (vscode-file://vscode-app/c:/Users/raymondzhao/work/vscode/out/vs/base/common/event.js:950:18)", source: vscode-file://vscode-app/c:/Users/raymondzhao/work/vscode/out/vs/base/common/lifecycle.js (23)

Metadata

Metadata

Labels

freeze-slow-crash-leakVS Code crashing, performance, freeze and memory leak issuesinsiders-releasedPatch has been released in VS Code InsiderstimelineTimeline view issues

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions