Skip to content

window.showQuickPick doesn't return when cancelled (esc key) with a long running items promise #22453

@eamodio

Description

@eamodio
  • VSCode Version: Code - Insiders 1.11.0-insider (01091bb, 2017-03-10T07:05:03.565Z)
  • OS Version: Darwin x64 16.4.0

Steps to Reproduce:

  1. Provide a long running (or infinite) promise to window.showQuickPick
  2. See the quick pick with the progress indication
  3. Press esc to cancel the quick pick
  4. Visibly the quick pick goes away, but window.showQuickPick doesn't return
  5. Expected that window.showQuickPick would return as soon as it was cancelled

Also if you provide an infinite promise (never resolves) window.showQuickPick never returns at all not matter what happens next (other quick picks are shown, etc)

Metadata

Metadata

Assignees

Labels

apibugIssue identified by VS Code Team member as probable bugquick-pickQuick-pick widget issuesverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions