Skip to content

Don't fire onDidEndTerminalShellExecution with exitCode undefined immediately after first onDidChangeTerminalShellIntegration #221399

Closed
Closed
Don't fire onDidEndTerminalShellExecution with exitCode undefined immediately after first onDidChangeTerminalShellIntegration#221399
Assignees
Tyriar
Labels
*not-reproducibleIssue cannot be reproduced by VS Code Team member as describedapibugIssue identified by VS Code Team member as probable bugterminalGeneral terminal issues that don't fall under another label
@Tyriar

Description

@Tyriar
Tyriar
opened on Jul 10, 2024

I think what is causing problems for @anthonykim1 is that calling executeCommand immediately after onDidChangeTerminalShellIntegration would fire multiple times and end up triggering an invalid onDidEndTerminalShellExecution with exitCode=undefined but the execution was set when it shouldn't have been. We should suppress this event if possible.

Metadata

Metadata

Assignees

Labels

*not-reproducibleIssue cannot be reproduced by VS Code Team member as describedapibugIssue identified by VS Code Team member as probable bugterminalGeneral terminal issues that don't fall under another label

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions