Currently using the git integration UI, git tries to push commits before testing if a password was entered. A test should be carried to make sure both fields have been entered before form submission.
- VSCode Version: 1.9.1
- OS Version: Ubuntu 16.04 LTS
Steps to Reproduce:
- Clone a repository eg.
git clone https://github.com/Microsoft/vscode.git
- Make changes, then try to push via the
git tab in the left bar
- Enter GitHub username
- Leave
password field blank
- Click OK button.
- Form should submit, but fail to push commits because password field was empty