-
Notifications
You must be signed in to change notification settings - Fork 40.3k
Shell integration with PowerShell 5.1 breaks with $ErrorActionPreference = 'stop' #190103
Copy link
Copy link
Closed
Closed
Copy link
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bughelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersterminal-shell-integrationShell integration infrastructure, command decorations, etc.Shell integration infrastructure, command decorations, etc.terminal-shell-pwshAn issue in the terminal specific to PowerShell, including shell integrationAn issue in the terminal specific to PowerShell, including shell integrationverifiedVerification succeededVerification succeeded
Milestone
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bughelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersterminal-shell-integrationShell integration infrastructure, command decorations, etc.Shell integration infrastructure, command decorations, etc.terminal-shell-pwshAn issue in the terminal specific to PowerShell, including shell integrationAn issue in the terminal specific to PowerShell, including shell integrationverifiedVerification succeededVerification succeeded
Type
Fields
Give feedbackNo fields configured for issues without a type.
Does this issue occur when all extensions are disabled?: Yes
Steps to Reproduce:
In
$PROFILE.CurrentUserAllHosts, set the content tothen start VS Code with shell integration enabled and use Windows PowerShell.
This bug will occur: PowerShell/PowerShellEditorServices#2050
The use of
$IsWindowsat:vscode/src/vs/workbench/contrib/terminal/browser/media/shellIntegration.ps1
Line 123 in 8429ea9
Needs to be guarded for Windows PowerShell (where it doesn't exist).
/cc @Tyriar