-
Notifications
You must be signed in to change notification settings - Fork 38.2k
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugcandidateIssue identified as probable candidate for fixing in the next releaseIssue identified as probable candidate for fixing in the next releaseterminal-shell-fishAn issue in the terminal specific to fish, including shell integrationAn issue in the terminal specific to fish, including shell integrationterminal-shell-integrationShell integration infrastructure, command decorations, etc.Shell integration infrastructure, command decorations, etc.verifiedVerification succeededVerification succeeded
Milestone
Description
Does this issue occur when all extensions are disabled?: Yes/No
- VS Code Version: 1.79.0-insider (system setup)
- Commit: b380da4
- OS Version: Remote on Ubuntu 22.04, Client on Win11
The reverted automated shell integration for fish done in #184363 is incomplete.
While the integration is no longer injected, a manual integration now fails as well because the script can't be found at the generated path.
$ set integration (code-insiders --locate-shell-integration-path fish)
$ stat $integration
stat: cannot statx '/home/max06/.vscode-server-insiders/bin/b380da4ef1ee00e224a15c1d4d9793e27c2b6302/out/vs/workbench/contrib/terminal/browser/media/shellIntegration.fish': No such file or directoryAfter digging in, I found a directory fish_xdg_data in the location where the script should have been.
$ tree fish_xdg_data/
fish_xdg_data/
└── fish
└── vendor_conf.d
└── shellIntegration.fishSomething got messed up 🍺
Just verified: Issue is present in 1.79.0 non-insiders - same git hash.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugcandidateIssue identified as probable candidate for fixing in the next releaseIssue identified as probable candidate for fixing in the next releaseterminal-shell-fishAn issue in the terminal specific to fish, including shell integrationAn issue in the terminal specific to fish, including shell integrationterminal-shell-integrationShell integration infrastructure, command decorations, etc.Shell integration infrastructure, command decorations, etc.verifiedVerification succeededVerification succeeded