Skip to content

ShellIntegration for fish is gone #184659

@max06

Description

@max06

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.79.0-insider (system setup)
  • Commit: b380da4
  • OS Version: Remote on Ubuntu 22.04, Client on Win11

The reverted automated shell integration for fish done in #184363 is incomplete.

While the integration is no longer injected, a manual integration now fails as well because the script can't be found at the generated path.

 $ set integration (code-insiders --locate-shell-integration-path fish)                                                                                                                             
 $ stat $integration                                                                                                                                                                                
stat: cannot statx '/home/max06/.vscode-server-insiders/bin/b380da4ef1ee00e224a15c1d4d9793e27c2b6302/out/vs/workbench/contrib/terminal/browser/media/shellIntegration.fish': No such file or directory

After digging in, I found a directory fish_xdg_data in the location where the script should have been.

 $ tree fish_xdg_data/                                                                                                                                                                              
fish_xdg_data/
└── fish
    └── vendor_conf.d
        └── shellIntegration.fish

Something got messed up 🍺

Just verified: Issue is present in 1.79.0 non-insiders - same git hash.

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugcandidateIssue identified as probable candidate for fixing in the next releaseterminal-shell-fishAn issue in the terminal specific to fish, including shell integrationterminal-shell-integrationShell integration infrastructure, command decorations, etc.verifiedVerification succeeded

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions