Terminals moved from an editor to the panel don't update "terminalEditorFocus" #173240
Description
Type: Bug
These context keys are set when a terminal editor is open and focused and the panel is not open
activeEditor: "terminalEditor"
activePanel: ""
focusedView: ""
panelFocus: false
terminalEditorActive: true
terminalEditorFocus: true
terminalFocus: true
And these context keys are set when the terminal view in the panel is open a focused and no editor is present
activeEditor: null
activePanel: "terminal"
focusedView: "terminal"
panelFocus: true
terminalEditorActive: false
terminalEditorFocus: false
terminalFocus: true
And these are the context keys after a terminal editor is moved to the panel
activeEditor: null
activePanel: "terminal"
focusedView: "terminal"
panelFocus: true
terminalEditorActive: false
terminalEditorFocus: true <-- Misbehaving
terminalFocus: true
In this last case notice that all the context keys match the expected values for a normal terminal in the panel except terminalEditorFocus. This ends up stuck to true. If you create a new terminal tab in the panel terminalEditorFocus will be set to false as expected. Returning to the terminal that was move will again set terminalEditorFocus to true.
Steps to repro:
- Create a terminal editor (workbench.action.createTerminalEditor)
- Move the terminal editor to the panel (workbench.action.terminal.moveToTerminalPanel)
- Inspect context keys (workbench.action.inspectContextKeys)
- Notice terminalEditorFocus is true
VS Code version: Code - Insiders 1.75.0-insider (e2816fe, 2023-02-01T15:16:18.248Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: Yes
System Info
| Item | Value |
|---|---|
| CPUs | AMD Ryzen 9 5950X 16-Core Processor (32 x 3400) |
| GPU Status | 2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off |
| Load (avg) | undefined |
| Memory (System) | 31.92GB (20.48GB free) |
| Process Argv | --crash-reporter-id 22cf4e37-a96e-4ad9-82f0-8715f8e2bf6e |
| Screen Reader | no |
| VM | 0% |
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30422396
pythontb:30258533
pythonptprofiler:30281269
vsdfh931cf:30280410
vshan820:30294714
pythondataviewer:30285072
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30404738
cppdebug:30492333
vsclangdf:30492506
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30618038
pylantcb52:30590116
pyindex848:30611229
nodejswelcome1:30587009
pyind779:30611226
pythonsymbol12:30651887
2i9eh265:30646982
showlangstatbar:30657381