Repository navigation
StateMainService: Avoid sync fs-calls #16387
Description
The StorageService reads/write from/to disk in a synchronous matter. This happens at startup, meaning creating of other services and the window is blocked by it.
{{ message }}
Activity
jrieken commentedon Dec 2, 2016
related to #15455
joaomoreno commentedon Dec 5, 2016
This is due to the nature of that service to not return promises in the
getcall.jrieken commentedon Dec 5, 2016
João Moreno (@joaomoreno) Apart from the messed up nature of that service I see a way to improve this: (1) create the service with the data already loaded (before calling its ctor) and (2) perform writes async
[-]Avoid sync fs-calls at startup[/-][+]StorageService: Avoid sync fs-calls[/+]bpasero commentedon Dec 21, 2018
The service no longer loads sync via 7024e62. The service is still writing sync though, but I am even thinking about maybe dropping the service in favour of our new storage service.
[-]StorageService: Avoid sync fs-calls[/-][+]StateMainService: Avoid sync fs-calls[/+]