Skip to content

Splitting terminal using "terminal.integrated.splitCwd": "workspaceRoot" always selects first option #163172

Description

@mradcliffe

Does this issue occur when all extensions are disabled?: Yes (via Start Extension Bisect)

  • VS Code Version: 1.72.0, 1.73.0-insider (Universal)
  • OS Version: Darwin x64 21.6.0

Steps to Reproduce:

  1. Open Visual Studio Code
  2. Confirm that Settings > Terminal > Integrated: Split Cwd is set to "workspaceRoot".
  3. Open a Workspace file.
  4. Open an Integrated Terminal from Terminal > New Terminal
  5. One of two methods:
    1. Click the "+" drop-down menu > Split Terminal > bash/zsh context menu option. This is my normal work flow because the the split button option below has been broken since the tab behavior was introduced.
    2. Press the split button.

Previous Behavior: When using 5.1, a drop-down menu is displayed at the top of Visual Studio Code until a selection is made.

Regression Behavior: When using either 5.1 or 5.2, a drop-down menu is briefly (<1 second) displayed and the first selection is always used without any user input and it is not possible to select a root folder using those methods.

Workaround: Use the command palette "Terminal: Split Terminal" command, which still offers the user a choice.

I did not capture a screen recording using Code 1.73.0-insiders, but I did test all 3 pathways to splitting a terminal using Code 1.73.0-insiders. This follows the steps to reproduce exactly as the only setting that I changed was Terminal > Integrated: Split Cwd.

I could have sworn I commented on either a pull request or an issue related to split terminal, but I can no longer find that issue in the issue queue (tried searching my username). But this is now a new regression that was not there in 1.71.x.

This is probably related to, but not a duplicate of, #117079.

Settings

Screenshot of Terminal > Integrated: Split Cwd workspaceRoot option

Video 1 (Using the split button) - Failure

Caption: I open an integrated terminal, it defaults to "test1". Then I try to use the "split" button. The drop-down briefly appears for less than one second, and a new integrated terminal opens in "test1".

integrated-terminal-split-button-regression.mov

Video 2 (Using the split context menu option) - Failure

Caption: I open an integrated terminal, it defaults to "test1". Then I try to use the drop-down menu from the "plus" button to select Split Terminal > zsh. The drop-down briefly appears for less than one second, and a new integrated terminal opens in "test1".

integrated-terminal-split-context-menu-regression.mov

Video 3 (Using the "Terminal: Split Terminal" command) - Success

Caption I open an integrated terminal, it defaults to "test1". Then I bring up the Command Palette using the keystroke, type to reach the the Terminal: Split Terminal command, select the command, the folder choice drop-down menu appears, I select "test2", and a new integrated terminal opens in "test2".

integrated-terminal-split-command-pallette.mov

Metadata

Metadata

Labels

bugIssue identified by VS Code Team member as probable bughelp wantedIssues identified as good community contribution opportunitiesinsiders-releasedPatch has been released in VS Code Insidersterminal-tabsverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions