Skip to content

tmTheme highlighting issues in vscode (Material Theme) #16206

@fredrikaverpil

Description

@fredrikaverpil

The Material Theme from the tmTheme editor doesn't render as intended per the tmTheme specs in vscode. I'm not sure if these themes are supposed to render in vscode exactly like they appear in the mtTheme editor?

  • VSCode Version: 1.7.2
  • OS Version: Windows 10, macOS Sierra/El Capitan

Steps to Reproduce:

  1. Download and install extension "Material Theme" by Fredrik Averpil (that's me)
  2. Enable extension and switch theme to "Material Theme"
  3. Copy paste the following and set syntax to Python:
def hello(some_option=None):
    """docstring here"""

    call_some_function(with_arg='some_string')
    self.call_other_function(with_arg='some_string')
    some_object.call_yet_another_function(with_arg='some_string')

Expected highlighting

As per Sublime Text:

sublime

...and tmTheme-Editor:

tmtheme-editor

Note

The docstring is rendered differently in Sublime Text, which I guess is because of a customization for Sublime, so please disregard this.

Actual highlighting in vscode:

vscode

Issues with vscode highlighting

  • Function arguments are not highlighted in orange (instead they are red)
  • Strings inside function calls are not highlighted in green (instead they are blue)
  • Objects are not highlighted in blue (instead they are white)

Additional information

The extension is using the exact same .tmTheme theme which can be downloaded from the tmTheme-editor. The theme is also maintained by Mattia Astorino and can be found in his git repo here. The theme file from tmTheme-editor and from Mattia's github repo are very similar and they both produce the same highlighting issue in vscode.

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugthemesColor theme issuesverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions