-
Notifications
You must be signed in to change notification settings - Fork 38.2k
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugthemesColor theme issuesColor theme issuesverifiedVerification succeededVerification succeeded
Milestone
Description
The Material Theme from the tmTheme editor doesn't render as intended per the tmTheme specs in vscode. I'm not sure if these themes are supposed to render in vscode exactly like they appear in the mtTheme editor?
- VSCode Version: 1.7.2
- OS Version: Windows 10, macOS Sierra/El Capitan
Steps to Reproduce:
- Download and install extension "Material Theme" by Fredrik Averpil (that's me)
- Enable extension and switch theme to "Material Theme"
- Copy paste the following and set syntax to Python:
def hello(some_option=None):
"""docstring here"""
call_some_function(with_arg='some_string')
self.call_other_function(with_arg='some_string')
some_object.call_yet_another_function(with_arg='some_string')Expected highlighting
As per Sublime Text:
...and tmTheme-Editor:
Note
The docstring is rendered differently in Sublime Text, which I guess is because of a customization for Sublime, so please disregard this.
Actual highlighting in vscode:
Issues with vscode highlighting
- Function arguments are not highlighted in orange (instead they are red)
- Strings inside function calls are not highlighted in green (instead they are blue)
- Objects are not highlighted in blue (instead they are white)
Additional information
The extension is using the exact same .tmTheme theme which can be downloaded from the tmTheme-editor. The theme is also maintained by Mattia Astorino and can be found in his git repo here. The theme file from tmTheme-editor and from Mattia's github repo are very similar and they both produce the same highlighting issue in vscode.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugthemesColor theme issuesColor theme issuesverifiedVerification succeededVerification succeeded


