Does this issue occur when all extensions are disabled?: Yes
- VS Code Version:
Version: 1.71.0 (Universal)
Commit: 784b017
Date: 2022-09-01T07:25:38.437Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 21.6.0
Sandboxed: No
Steps to Reproduce:
- Start vscode as a non-root user
- Use a remote extension like codespaces
- Have a setup that forwards a port below 1024 ie port 80
- After the connection the port is forward to a random number
This is annoying if you are working on a server and want to use a local domain ie myProject.localhost which requires the mapping to port 80. OSX does not enforce root for binding to ports below 1024 so I think vscode should also not treat them as privileged.
I wanted to submit a pr for this, but it is hard to test codespaces/remote container dev with vscode OSS.
My first impression is that I would only need to change the definition of a privileged port here:
https://github.com/microsoft/vscode/blob/main/src/vs/platform/tunnel/common/tunnel.ts#L158-L164
Does this issue occur when all extensions are disabled?: Yes
Version: 1.71.0 (Universal)
Commit: 784b017
Date: 2022-09-01T07:25:38.437Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 21.6.0
Sandboxed: No
Steps to Reproduce:
This is annoying if you are working on a server and want to use a local domain ie
myProject.localhostwhich requires the mapping to port 80. OSX does not enforce root for binding to ports below 1024 so I think vscode should also not treat them as privileged.I wanted to submit a pr for this, but it is hard to test codespaces/remote container dev with vscode OSS.
My first impression is that I would only need to change the definition of a privileged port here:
https://github.com/microsoft/vscode/blob/main/src/vs/platform/tunnel/common/tunnel.ts#L158-L164