Skip to content

Retain hue when contrast shifts luminance in other direction #156984

@Tyriar

Description

@Tyriar

xterm.js issue: xtermjs/xterm.js#3845

Currently if contrast can't be met going the natural direction, we switch and go the other direction but this is done by using the background as the foreground. This causes the flipped color to be greyscale:

image

It would be better if the hue was retained.

Metadata

Metadata

Assignees

Labels

accessibilityKeyboard, mouse, ARIA, vision, screen readers (non-specific) issuesbugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code Insidersterminal-renderingupstreamIssue identified as 'upstream' component related (exists outside of VS Code)upstream-issue-fixedThe underlying upstream issue has been fixedupstream-issue-linkedThis is an upstream issue that has been reported upstreamverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions