-
Notifications
You must be signed in to change notification settings - Fork 38.9k
Retain hue when contrast shifts luminance in other direction #156984
Copy link
Copy link
Closed
Labels
accessibilityKeyboard, mouse, ARIA, vision, screen readers (non-specific) issuesKeyboard, mouse, ARIA, vision, screen readers (non-specific) issuesbugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersterminal-renderingupstreamIssue identified as 'upstream' component related (exists outside of VS Code)Issue identified as 'upstream' component related (exists outside of VS Code)upstream-issue-fixedThe underlying upstream issue has been fixedThe underlying upstream issue has been fixedupstream-issue-linkedThis is an upstream issue that has been reported upstreamThis is an upstream issue that has been reported upstreamverifiedVerification succeededVerification succeeded
Milestone
Description
xterm.js issue: xtermjs/xterm.js#3845
Currently if contrast can't be met going the natural direction, we switch and go the other direction but this is done by using the background as the foreground. This causes the flipped color to be greyscale:
It would be better if the hue was retained.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
accessibilityKeyboard, mouse, ARIA, vision, screen readers (non-specific) issuesKeyboard, mouse, ARIA, vision, screen readers (non-specific) issuesbugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersterminal-renderingupstreamIssue identified as 'upstream' component related (exists outside of VS Code)Issue identified as 'upstream' component related (exists outside of VS Code)upstream-issue-fixedThe underlying upstream issue has been fixedThe underlying upstream issue has been fixedupstream-issue-linkedThis is an upstream issue that has been reported upstreamThis is an upstream issue that has been reported upstreamverifiedVerification succeededVerification succeeded
