Skip to content

Editor terminal issues #152302

Description

@pfitzseb

Does this issue occur when all extensions are disabled?: Probably, but that's hard to test

  • VS Code Version: 1.69.0-insider and 1.68
  • OS Version: Linux x64 5.17.9-1-MANJARO

There are a few issues related to terminals in editor tabs (instead of the dedicated terminal pane).

onDidCloseTerminal does not trigger when underlying process dies

Steps to Reproduce:

  1. Run the terminal-sample extension
  2. Use the terminalTest.createTerminal command
  3. Drag the resulting terminal into the main workspace (or set terminal.integrated.defaultLocation to editor beforehand)
  4. Close the terminal by killing the underlying process (e.g. ^D in your shell)
  5. No onDidCloseTerminal notification appears.

terminal.exitCode is not set when underlying process dies

I assume this has the same root cause as the first issue. To repro, follow the steps outlined above and then

  1. set a breakpoint in the terminalTest.show handler
  2. Use the terminalTest.show command and select the terminal you just created (and closed)
  3. Check that terminal.exitCode === undefined in the debugger.

Terminal's viewColumn is inaccessible

It's easy enough to open a terminal in a viewColumn, but there's no robust way to query where a terminal currently is. Terminal doesn't expose a viewColumn property and the new tab API's tab.input property doesn't point back to a specific terminal either.

This means that if an extension provides a command to create and show a terminal, it's impossible to show it at the same position the user had it before; a WebviewPanel.onDidChangeViewState API would help with that.

Metadata

Metadata

Labels

apifeature-requestRequest for new features or functionalityterminalGeneral terminal issues that don't fall under another label

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions