Skip to content

Next terminal is not focused when a shell process dies on its own (then terminalFocus doesn't act as expected) #15103

@kaiwood

Description

@kaiwood
  • VSCode Version: 1.7.1
  • OS Version: macOS Sierra 10.12.1 (16B2555)

Steps to Reproduce for "open":

  1. Toggle terminal pane
  2. Start a second terminal (via shortcut or click on '+')
  3. Try using a set shortcut for workbench.action.terminal.focusNext / workbench.action.terminal.focusPrevious
  4. At this point, the values of setting terminal.integrated.commandsToSkipShell get ignored, shortcuts don't work and the pressed key reaches the terminal
  5. Toggling terminal pane twice to ensure that terminalFocus ist set and everything works as expected.

terminal_1

Steps to Reproduces for "close":

  1. Open a terminal pane with 2+ terminals
  2. Close a terminal (by typing "exit" or "ctrl-d")
  3. terminalFocus is is lost and shortcuts get send to the editor instead (shortcuts for switching terminals in the animated screenshot are set to the same as next/previous tab)
  4. Notice that the cursor in the terminal even shows that it has no focus - unlike in the first example, where the cursor stays the same!
  5. Toggle terminal pane twice to make everything work again

terminal_2

PS: Yes, --disable-extensions was used ;)

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugterminalGeneral terminal issues that don't fall under another labelverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions