-
Notifications
You must be signed in to change notification settings - Fork 38.9k
Closed
Labels
Milestone
Description
Refs #134791
- Windows @joyceerhl
- macOS @isidorn
- Linux @brettcannon
Authors: @meganrogge @Tyriar
Complexity: 3
We have implemented find result count in the terminal in order to align with that in the editor now that we show decorations for the find result.
At the moment, decorations are a bit costly, so we will avoid showing them and not calculate the result count when there are > 2000 results. This number was chosen based upon when I saw a substantial performance impact.
When we implement decorations differently, via drawing to the canvas instead of inserting DOM elements, this will be resolved.
Verify that when there are:
- 0 results,
No Resultsis shown - Less than 2000 results, the number of results is shown and running
findNextandfindPreviousupdates the currently selected index - Greater than or equal to 2000 results, no find result decorations are shown and there is no label in the find widget
Reactions are currently unavailable
