Skip to content

Test: terminal find result count label #148060

@meganrogge

Description

@meganrogge

Refs #134791

Authors: @meganrogge @Tyriar

Complexity: 3

Create Issue


We have implemented find result count in the terminal in order to align with that in the editor now that we show decorations for the find result.

Screen Shot 2022-04-25 at 9 32 13 AM

At the moment, decorations are a bit costly, so we will avoid showing them and not calculate the result count when there are > 2000 results. This number was chosen based upon when I saw a substantial performance impact.

When we implement decorations differently, via drawing to the canvas instead of inserting DOM elements, this will be resolved.

Verify that when there are:

  • 0 results, No Results is shown
  • Less than 2000 results, the number of results is shown and running findNext and findPrevious updates the currently selected index
  • Greater than or equal to 2000 results, no find result decorations are shown and there is no label in the find widget

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions