Skip to content

Move command invalidation from decoration addon to command detection capability #145893

Closed
#147116
#146563
Closed
Move command invalidation from decoration addon to command detection capability#145893
#147116
#146563
Assignees
Tyriar
Labels
bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code Insidersterminal-persistenceRelating to process reconnection or process reviveterminal-shell-integrationShell integration infrastructure, command decorations, etc.verifiedVerification succeeded
Milestone
May 2022
@Tyriar

Description

@Tyriar
Tyriar
opened on Mar 23, 2022

We currently have this which runs on the renderer process only:

vscode/src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts

Lines 174 to 180 in 483ec48

this._commandFinishedListener = capability.onCommandFinished(command => {
if (command.command.trim().toLowerCase() === 'clear' || command.command.trim().toLowerCase() === 'cls') {
this.clearDecorations();
return;
}
this.registerCommandDecoration(command);
});

What we should do instead to ensure these changes carry over across reconnects is to mark commands as invalid or something and fire an event inside the command detection capability. The decorations addon would then listen to it and react accordingly.

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code Insidersterminal-persistenceRelating to process reconnection or process reviveterminal-shell-integrationShell integration infrastructure, command decorations, etc.verifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions