-
Notifications
You must be signed in to change notification settings - Fork 38.9k
improve decoration rendering efficiency #145751
Copy link
Copy link
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersperfterminal-findRelating the terminal's find widgetRelating the terminal's find widgetterminal-shell-integrationShell integration infrastructure, command decorations, etc.Shell integration infrastructure, command decorations, etc.upstreamIssue identified as 'upstream' component related (exists outside of VS Code)Issue identified as 'upstream' component related (exists outside of VS Code)upstream-issue-fixedThe underlying upstream issue has been fixedThe underlying upstream issue has been fixedupstream-issue-linkedThis is an upstream issue that has been reported upstreamThis is an upstream issue that has been reported upstreamverifiedVerification succeededVerification succeeded
Milestone
Description
Testing #145629
Could repro this slowness by filling the buffer and then searching for a single letter, this is on a 12th gen i7 (fast modern CPU):
A similar thing happens when pressing enter in this state since we don't do any diffing, just clear and re-render.
Ideas to explore:
- Move from rendering each decoration to calculating colored zones which merge similar rectangles into the same zone and render them
- If the buffer is full, explore shifting the texture up depending on how much scrolling occurs (might be tricky to get right)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersperfterminal-findRelating the terminal's find widgetRelating the terminal's find widgetterminal-shell-integrationShell integration infrastructure, command decorations, etc.Shell integration infrastructure, command decorations, etc.upstreamIssue identified as 'upstream' component related (exists outside of VS Code)Issue identified as 'upstream' component related (exists outside of VS Code)upstream-issue-fixedThe underlying upstream issue has been fixedThe underlying upstream issue has been fixedupstream-issue-linkedThis is an upstream issue that has been reported upstreamThis is an upstream issue that has been reported upstreamverifiedVerification succeededVerification succeeded
