-
Notifications
You must be signed in to change notification settings - Fork 38.8k
Closed
Labels
accessibilityKeyboard, mouse, ARIA, vision, screen readers (non-specific) issuesKeyboard, mouse, ARIA, vision, screen readers (non-specific) issuesbugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersterminal-findRelating the terminal's find widgetRelating the terminal's find widgetverifiedVerification succeededVerification succeeded
Milestone
Description
Testing #145629
We draw the find match selection on top of the text which reduces contrast pretty badly
Terminal:
Editor:
Should we use a border instead of a solid rectangle to workaround this? It would look different from the editor but at least it wouldn't introduce contrast problems
This is what it looks like with these style overrides:
.xterm-decoration.xterm-find-result-decoration {
border: 1px solid rgba(234, 92, 0, 1) !important;
box-sizing: border-box;
background: transparent !important;
}The white background on selection is due to "terminal.selectionBackground": "#ffffff"
We should support border styles anyway to cover the high contrast case:
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
accessibilityKeyboard, mouse, ARIA, vision, screen readers (non-specific) issuesKeyboard, mouse, ARIA, vision, screen readers (non-specific) issuesbugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersterminal-findRelating the terminal's find widgetRelating the terminal's find widgetverifiedVerification succeededVerification succeeded




