Skip to content

Contrast isn't great in find results #145744

@Tyriar

Description

@Tyriar

Testing #145629

We draw the find match selection on top of the text which reduces contrast pretty badly

Terminal:

image
image

Editor:

image

Should we use a border instead of a solid rectangle to workaround this? It would look different from the editor but at least it wouldn't introduce contrast problems

This is what it looks like with these style overrides:

.xterm-decoration.xterm-find-result-decoration {
    border: 1px solid rgba(234, 92, 0, 1) !important;
    box-sizing: border-box;
    background: transparent !important;
}

image

The white background on selection is due to "terminal.selectionBackground": "#ffffff"

We should support border styles anyway to cover the high contrast case:

image

Metadata

Metadata

Assignees

Labels

accessibilityKeyboard, mouse, ARIA, vision, screen readers (non-specific) issuesbugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code Insidersterminal-findRelating the terminal's find widgetverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions