-
Notifications
You must be signed in to change notification settings - Fork 36.8k
Closed
Labels
debtCode quality issuesCode quality issuessandboxRunning VSCode in a node-free environmentRunning VSCode in a node-free environmentterminalGeneral terminal issues that don't fall under another labelGeneral terminal issues that don't fall under another label
Milestone
Description
Now that the terminals are managed from the shared process it would be great if this dependency here:
vscode/src/vs/workbench/workbench.desktop.main.ts
Lines 133 to 134 in 79a623d
| // Terminal | |
| import 'vs/workbench/contrib/terminal/electron-browser/terminal.contribution'; |
Could fully move into electron-sandbox (into src/vs/workbench/workbench.sandbox.main.ts) so that we can even test it from running scripts/code.sh --__sandbox
Metadata
Metadata
Assignees
Labels
debtCode quality issuesCode quality issuessandboxRunning VSCode in a node-free environmentRunning VSCode in a node-free environmentterminalGeneral terminal issues that don't fall under another labelGeneral terminal issues that don't fall under another label