Skip to content

Terminal: move workbench dependencies into electron-sandbox #117257

@bpasero

Description

@bpasero

Now that the terminals are managed from the shared process it would be great if this dependency here:

// Terminal
import 'vs/workbench/contrib/terminal/electron-browser/terminal.contribution';

Could fully move into electron-sandbox (into src/vs/workbench/workbench.sandbox.main.ts) so that we can even test it from running scripts/code.sh --__sandbox

Metadata

Metadata

Labels

debtCode quality issuessandboxRunning VSCode in a node-free environmentterminalGeneral terminal issues that don't fall under another label

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions