-
Notifications
You must be signed in to change notification settings - Fork 38.2k
Closed
Labels
configVS Code configuration, settingsVS Code configuration, settingsdebtCode quality issuesCode quality issues
Milestone
Description
See #109278 (comment).
We have many places that enforce to update settings in ConfigurationTarget.USER which is a no-op if the setting is configured on a workspace level. ConfigurationService.updateValue derives the target appropriately if the target is not passed. So please double check your usage of this method and do not pass ConfigurationTarget.USER target if your intention is to change the effective value.
- src/vs/workbench/browser/actions/layoutActions.ts @bpasero
- src/vs/workbench/browser/actions/windowActions.ts @bpasero
- src/vs/workbench/browser/parts/editor/editorCommands.ts @alexdima
- src/vs/workbench/browser/parts/editor/editorStatus.ts @alexdima
- src/vs/workbench/contrib/codeEditor/browser/accessibility/accessibility.ts @alexdima
- src/vs/workbench/contrib/codeEditor/browser/diffEditorHelper.ts @alexdima
- src/vs/workbench/contrib/codeEditor/browser/toggleColumnSelection.ts @alexdima
- src/vs/workbench/contrib/codeEditor/browser/toggleMinimap.ts @alexdima
- src/vs/workbench/contrib/codeEditor/browser/toggleMultiCursorModifier.ts @alexdima
- src/vs/workbench/contrib/codeEditor/browser/toggleRenderControlCharacter.ts @alexdima
- src/vs/workbench/contrib/codeEditor/browser/toggleRenderWhitespace.ts @alexdima
- src/vs/workbench/contrib/extensions/browser/extensionRecommendationNotificationService.ts @sandy081
- src/vs/workbench/contrib/files/browser/fileActions.ts @isidorn
- src/vs/workbench/contrib/files/browser/views/explorerViewer.ts @isidorn
- src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts @alexr00
- src/vs/workbench/contrib/terminal/browser/terminalInstance.ts @Tyriar
- src/vs/workbench/contrib/terminal/browser/terminalService.ts @Tyriar
- src/vs/workbench/contrib/welcome/page/browser/welcomePage.ts @chrmarti
- src/vs/workbench/services/themes/common/themeConfiguration.ts @aeschli
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
configVS Code configuration, settingsVS Code configuration, settingsdebtCode quality issuesCode quality issues