-
Notifications
You must be signed in to change notification settings - Fork 38.2k
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersverifiedVerification succeededVerification succeededwebviewWebview issuesWebview issues
Milestone
Description
- VSCode Version: 1.48.2 to latest insiders
- OS Version: linux kernel 4.18
Steps to Reproduce:
- In an extension, create a webview which uses FileSaver js library , to save something in a file from a "save" button within the webview
- Make sure you load the webview with
{ enableScripts: true, retainContextWhenHidden: true, enableCommandUris:true } - try the extension. In VSCode before 1.48, there was no problem
The extension where I discovered the problem is senx.warpscript-language , in the WarpScript image webview.
Does this issue occur when all extensions are disabled?: No
It seems Chrome engine added another layer to sandbox default security in the meantime, now allow-downloads is necessary within the iframe sandbox settings. PR coming soon.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersverifiedVerification succeededVerification succeededwebviewWebview issuesWebview issues