-
Notifications
You must be signed in to change notification settings - Fork 38.2k
Closed
Labels
engineeringVS Code - Build / issue tracking / etc.VS Code - Build / issue tracking / etc.
Milestone
Description
Continuation of #106285 and part of the TrustedTypes effort (see #103699). To get a list of violations
- run
yarn tsec-compile-check
Or, get the list of violations from edge/chrome directly
- run
yarn web --trusted-types - open http://localhost:8080/ in Edge or Chrome
- open console and check for "[Report Only] This document requires 'TrustedHTML' assignment."-messages
Also, there is .vscode/searches/TrustedTypes.code-search which finds all occurences of innerHTML. There are common sources of violation and therefore common fixes
- styling via
style.innerHTML➡️ usetextContentinstead (example c112f84) - clear a node via
node.innerHTML = ''➡️ usedom.ts#clearNodeornode.innerText = '' - building dom nodes ➡️ use
dom.$ordocument.createElementand friends
- menu.js:151 @sbatten
- sash.js:35 @joaomoreno
- walkThroughPart.js:208 @chrmarti
- welcomePage.js:259 @chrmarti
- selectBoxCustom.ts @isidorn
- quickInput.ts @chrmarti
- issueReporterMain @RMacfarlane
- processExplorerMain @RMacfarlane
- repl.ts @isidorn
- commentThreadWidget.ts @RMacfarlane
- commentsView.ts @RMacfarlane
-
cellRenderer.ts@roblourens - webviewIconManager.ts @mjbvz
- workbench.js @jrieken
- contextView.ts#160 @sbatten
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
engineeringVS Code - Build / issue tracking / etc.VS Code - Build / issue tracking / etc.