Skip to content

Trusted Types compatibility: use DOM API for creating HTML elements instead of string concatenation in welcomeOverlay.ts #105505

@annkamsk

Description

@annkamsk

The next step in resolving #103699. The Trusted Types violation here is setting an HTMLElement’s text content by assigning it to .innerHTML. Because in all of the cases the HTMLElement is already created with dom.ts#$ function, the idea is to pass the text as its children argument.
That is to replace: dom.append(parent, $(‘span’)).innerHTML = text with dom.append(parent, $(‘span’, {}, text)).

Metadata

Metadata

Assignees

Labels

engineeringVS Code - Build / issue tracking / etc.insiders-releasedPatch has been released in VS Code Insidersworkbench-welcomeWelcome page issues

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions