Skip to content

“Enable Commit Signing” config label names only GPG, but X.509 is also supported #105227

@marvinruder

Description

@marvinruder

Issue Type: Feature Request

git supports commit signing using either GPG or X.509. VS Code apparently supports using both methods, since it uses the signing method that git is set to use (probably by just calling git commit -S).

However, the “Enable Commit Signing” configuration label names explicitly GPG as signing method. If X.509 is set to be used by git, it is also used when commiting using VS Code's git interface, although the user selected “Enable Commit Signing with GPG”.

Renaming the “Enable Commit Signing” configuration label to include both GPG and X.509 would solve this inconsistence.

VS Code version: Code 1.48.1 (3dd9051, 2020-08-19T17:09:41.484Z)
OS version: Darwin x64 20.0.0

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable buggitGIT issuesinsiders-releasedPatch has been released in VS Code InsidersverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions