-
Notifications
You must be signed in to change notification settings - Fork 39k
“Enable Commit Signing” config label names only GPG, but X.509 is also supported #105227
Copy link
Copy link
Closed
Closed
Copy link
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buggitGIT issuesGIT issuesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersverifiedVerification succeededVerification succeeded
Milestone
Description
Issue Type: Feature Request
git supports commit signing using either GPG or X.509. VS Code apparently supports using both methods, since it uses the signing method that git is set to use (probably by just calling git commit -S).
However, the “Enable Commit Signing” configuration label names explicitly GPG as signing method. If X.509 is set to be used by git, it is also used when commiting using VS Code's git interface, although the user selected “Enable Commit Signing with GPG”.
Renaming the “Enable Commit Signing” configuration label to include both GPG and X.509 would solve this inconsistence.
VS Code version: Code 1.48.1 (3dd9051, 2020-08-19T17:09:41.484Z)
OS version: Darwin x64 20.0.0
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buggitGIT issuesGIT issuesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersverifiedVerification succeededVerification succeeded