-
Notifications
You must be signed in to change notification settings - Fork 39k
completeFunctionCalls should not add this parameters #104877
Copy link
Copy link
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsiderstypescriptTypescript support issuesTypescript support issuesverifiedVerification succeededVerification succeeded
Milestone
Description
- VSCode Version: 1.47.3
- OS Version: Darwin x64 18.7.0
Steps to Reproduce:
- Enable completeFunctionCall
- Create new tyepscript file, ype
function f(this: void) {
// make sure `this` is unusable in this standalone function
}
f|cursor at |
3. TAB
Expected: f()
Actual: f(this)
Typescript allow annotating
thisparameter https://www.typescriptlang.org/docs/handbook/functions.html#this-parametersfunction f(this: void) { // make sure `this` is unusable in this standalone function }Because
thisparameters are fake parameters, I think we should skip these.
Does this issue occur when all extensions are disabled?: Yes/No
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsiderstypescriptTypescript support issuesTypescript support issuesverifiedVerification succeededVerification succeeded