Skip to content

Environment service debt between common, browser, native #102918

@inspirer

Description

@inspirer

There are common and browser versions of the environment service but both of them depend on workbench.web.api.ts for IWorkbenchConstructionOptions. This is a type only dependency so it should not create any problems at runtime but it is misleading since common code gets access to browser-only interfaces such as IUpdateProvider.

The culprit seems to be the unclear status of workbench.web.api inside .eslintrc.json.

See https://github.com/microsoft/vscode/wiki/Source-Code-Organization#target-environments

Metadata

Metadata

Assignees

Labels

*out-of-scopePosted issue is not in scope of VS CodedebtCode quality issues

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions