Add "new session" to chat context menu (#198376)

roblourens · web-flow · commit 956bfb6a0210 · 2023-11-16T01:14:44.000+01:00
From discussion
diff --git a/src/vs/workbench/contrib/chat/browser/actions/chatClearActions.ts b/src/vs/workbench/contrib/chat/browser/actions/chatClearActions.ts
@@ -63,19 +63,23 @@ export function registerClearActions() {
 						primary: KeyMod.WinCtrl | KeyCode.KeyL
 					},
 					when: CONTEXT_IN_CHAT_SESSION
+				},
+				menu: {
+					id: MenuId.ChatContext,
+					group: 'z_clear'
 				}
 			});
 		}
 
 		run(accessor: ServicesAccessor, ...args: any[]) {
-			announceChatCleared(accessor);
 			const widgetService = accessor.get(IChatWidgetService);
 
 			const widget = widgetService.lastFocusedWidget;
 			if (!widget) {
 				return;
 			}
 
+			announceChatCleared(accessor);
 			widget.clear();
 		}
 	});
diff --git a/src/vs/workbench/contrib/chat/browser/actions/chatCopyActions.ts b/src/vs/workbench/contrib/chat/browser/actions/chatCopyActions.ts
@@ -23,7 +23,8 @@ export function registerChatCopyActions() {
 				f1: false,
 				category: CHAT_CATEGORY,
 				menu: {
-					id: MenuId.ChatContext
+					id: MenuId.ChatContext,
+					group: 'copy',
 				}
 			});
 		}
@@ -56,7 +57,8 @@ export function registerChatCopyActions() {
 				f1: false,
 				category: CHAT_CATEGORY,
 				menu: {
-					id: MenuId.ChatContext
+					id: MenuId.ChatContext,
+					group: 'copy',
 				}
 			});
 		}

Original file line number	Diff line number	Diff line change
`@@ -63,19 +63,23 @@ export function registerClearActions() {`
`63`	`63`	`primary: KeyMod.WinCtrl \| KeyCode.KeyL`
`64`	`64`	`},`
`65`	`65`	`when: CONTEXT_IN_CHAT_SESSION`
	`66`	`+ },`
	`67`	`+ menu: {`
	`68`	`+ id: MenuId.ChatContext,`
	`69`	`+ group: 'z_clear'`
`66`	`70`	`}`
`67`	`71`	`});`
`68`	`72`	`}`
`69`	`73`
`70`	`74`	`run(accessor: ServicesAccessor, ...args: any[]) {`
`71`		`- announceChatCleared(accessor);`
`72`	`75`	`const widgetService = accessor.get(IChatWidgetService);`
`73`	`76`
`74`	`77`	`const widget = widgetService.lastFocusedWidget;`
`75`	`78`	`if (!widget) {`
`76`	`79`	`return;`
`77`	`80`	`}`
`78`	`81`
	`82`	`+ announceChatCleared(accessor);`
`79`	`83`	`widget.clear();`
`80`	`84`	`}`
`81`	`85`	`});`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,8 @@ export function registerChatCopyActions() {`
`23`	`23`	`f1: false,`
`24`	`24`	`category: CHAT_CATEGORY,`
`25`	`25`	`menu: {`
`26`		`- id: MenuId.ChatContext`
	`26`	`+ id: MenuId.ChatContext,`
	`27`	`+ group: 'copy',`
`27`	`28`	`}`
`28`	`29`	`});`
`29`	`30`	`}`
`@@ -56,7 +57,8 @@ export function registerChatCopyActions() {`
`56`	`57`	`f1: false,`
`57`	`58`	`category: CHAT_CATEGORY,`
`58`	`59`	`menu: {`
`59`		`- id: MenuId.ChatContext`
	`60`	`+ id: MenuId.ChatContext,`
	`61`	`+ group: 'copy',`
`60`	`62`	`}`
`61`	`63`	`});`
`62`	`64`	`}`