Skip to content

Commit 699c9ad

Browse files
committed
scm: require integer gutter width values
1 parent 29e4149 commit 699c9ad

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

‎src/vs/workbench/contrib/scm/browser/quickDiffDecorator.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const DEFAULT_DIFF_DECORATIONS_GUTTER_WIDTH = 3;
3232
const MAX_DIFF_DECORATIONS_GUTTER_WIDTH = 20;
3333

3434
export function normalizeDiffDecorationsGutterWidth(width: number): number {
35-
if (isNaN(width) || width <= 0 || width > MAX_DIFF_DECORATIONS_GUTTER_WIDTH) {
35+
if (!Number.isInteger(width) || width <= 0 || width > MAX_DIFF_DECORATIONS_GUTTER_WIDTH) {
3636
return DEFAULT_DIFF_DECORATIONS_GUTTER_WIDTH;
3737
}
3838

‎src/vs/workbench/contrib/scm/browser/scm.contribution.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration).regis
197197
description: localize('diffDecorations', "Controls diff decorations in the editor.")
198198
},
199199
'scm.diffDecorationsGutterWidth': {
200-
type: 'number',
200+
type: 'integer',
201201
minimum: 1,
202202
maximum: 20,
203203
default: 3,

‎src/vs/workbench/contrib/scm/test/browser/quickDiffDecorator.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ suite('normalizeDiffDecorationsGutterWidth', () => {
1616
test('falls back for invalid values', () => {
1717
assert.strictEqual(normalizeDiffDecorationsGutterWidth(0), 3);
1818
assert.strictEqual(normalizeDiffDecorationsGutterWidth(-1), 3);
19+
assert.strictEqual(normalizeDiffDecorationsGutterWidth(1.5), 3);
1920
assert.strictEqual(normalizeDiffDecorationsGutterWidth(21), 3);
2021
assert.strictEqual(normalizeDiffDecorationsGutterWidth(Number.NaN), 3);
2122
});

0 commit comments

Comments
 (0)