Disable md paste file path in untitled notebooks (#198372)

mjbvz · web-flow · commit 4f303bb42cf7 · 2023-11-16T00:31:39.000+01:00
Fixes #194809 Since the notebook does not exist on disk yet, there's no way to write a relative path in it. Just disable the feature since there's nothing else we can reasonably do here
diff --git a/extensions/markdown-language-features/src/languageFeatures/copyFiles/dropResourceProvider.ts b/extensions/markdown-language-features/src/languageFeatures/copyFiles/dropResourceProvider.ts
@@ -7,6 +7,7 @@ import * as vscode from 'vscode';
 import { Mime, mediaMimes } from '../../util/mimes';
 import { Schemes } from '../../util/schemes';
 import { createEditForMediaFiles, tryGetUriListSnippet } from './shared';
+import { getParentDocumentUri } from '../../util/document';
 
 class ResourceDropProvider implements vscode.DocumentDropEditProvider {
 
@@ -58,7 +59,7 @@ class ResourceDropProvider implements vscode.DocumentDropEditProvider {
 	}
 
 	private async _getMediaFilesEdit(document: vscode.TextDocument, dataTransfer: vscode.DataTransfer, token: vscode.CancellationToken): Promise<vscode.DocumentDropEdit | undefined> {
-		if (document.uri.scheme === Schemes.untitled) {
+		if (getParentDocumentUri(document.uri).scheme === Schemes.untitled) {
 			return;
 		}
 
diff --git a/extensions/markdown-language-features/src/languageFeatures/copyFiles/pasteResourceProvider.ts b/extensions/markdown-language-features/src/languageFeatures/copyFiles/pasteResourceProvider.ts
@@ -7,6 +7,7 @@ import * as vscode from 'vscode';
 import { Mime, mediaMimes } from '../../util/mimes';
 import { Schemes } from '../../util/schemes';
 import { PasteUrlAsFormattedLink, createEditAddingLinksForUriList, createEditForMediaFiles, getPasteUrlAsFormattedLinkSetting } from './shared';
+import { getParentDocumentUri } from '../../util/document';
 
 class PasteResourceEditProvider implements vscode.DocumentPasteEditProvider {
 
@@ -64,7 +65,7 @@ class PasteResourceEditProvider implements vscode.DocumentPasteEditProvider {
 	}
 
 	private async _getMediaFilesEdit(document: vscode.TextDocument, dataTransfer: vscode.DataTransfer, token: vscode.CancellationToken): Promise<vscode.DocumentPasteEdit | undefined> {
-		if (document.uri.scheme === Schemes.untitled) {
+		if (getParentDocumentUri(document.uri).scheme === Schemes.untitled) {
 			return;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@ import * as vscode from 'vscode';`
`7`	`7`	`import { Mime, mediaMimes } from '../../util/mimes';`
`8`	`8`	`import { Schemes } from '../../util/schemes';`
`9`	`9`	`import { createEditForMediaFiles, tryGetUriListSnippet } from './shared';`
	`10`	`+import { getParentDocumentUri } from '../../util/document';`
`10`	`11`
`11`	`12`	`class ResourceDropProvider implements vscode.DocumentDropEditProvider {`
`12`	`13`
`@@ -58,7 +59,7 @@ class ResourceDropProvider implements vscode.DocumentDropEditProvider {`
`58`	`59`	`}`
`59`	`60`
`60`	`61`	`private async _getMediaFilesEdit(document: vscode.TextDocument, dataTransfer: vscode.DataTransfer, token: vscode.CancellationToken): Promise<vscode.DocumentDropEdit \| undefined> {`
`61`		`- if (document.uri.scheme === Schemes.untitled) {`
	`62`	`+ if (getParentDocumentUri(document.uri).scheme === Schemes.untitled) {`
`62`	`63`	`return;`
`63`	`64`	`}`
`64`	`65`