fix: prevent stale badge cache after badgeDisposable is cleared

murataslan1 · Copilot · murataslan1 · commit 2e5b84814aaa · 2026-02-17T10:30:11.000+03:00
Include badgeDisposable.value in the early-return cache check so that
badges are properly re-applied after results are cleared (e.g. when
badgeDisposable.clear() is called in the no-results branch) and tests
start again.

Co-authored-by: Copilot &lt;223556219+Copilot@users.noreply.github.com&gt;
diff --git a/src/vs/workbench/contrib/testing/browser/testingExplorerView.ts b/src/vs/workbench/contrib/testing/browser/testingExplorerView.ts
@@ -636,19 +636,19 @@ class ResultSummaryView extends Disposable {
 
 	private renderActivityBadge(countSummary: CountSummary, isRunning: boolean) {
 		if (isRunning) {
-			if (this.lastBadge instanceof IconBadge && this.lastBadge.icon === spinningLoading) {
+			if (this.badgeDisposable.value && this.lastBadge instanceof IconBadge && this.lastBadge.icon === spinningLoading) {
 				return;
 			}
 
 			this.lastBadge = new IconBadge(spinningLoading, () => localize('testingRunningBadge', 'Tests are running'));
 		} else if (countSummary && this.badgeType !== TestingCountBadge.Off && countSummary[this.badgeType] !== 0) {
-			if (this.lastBadge instanceof NumberBadge && this.lastBadge.number === countSummary[this.badgeType]) {
+			if (this.badgeDisposable.value && this.lastBadge instanceof NumberBadge && this.lastBadge.number === countSummary[this.badgeType]) {
 				return;
 			}
 
 			this.lastBadge = new NumberBadge(countSummary[this.badgeType], num => this.getLocalizedBadgeString(this.badgeType, num));
 		} else if (this.crService.isEnabled()) {
-			if (this.lastBadge instanceof IconBadge && this.lastBadge.icon === icons.testingContinuousIsOn) {
+			if (this.badgeDisposable.value && this.lastBadge instanceof IconBadge && this.lastBadge.icon === icons.testingContinuousIsOn) {
 				return;
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -636,19 +636,19 @@ class ResultSummaryView extends Disposable {`
`636`	`636`
`637`	`637`	`private renderActivityBadge(countSummary: CountSummary, isRunning: boolean) {`
`638`	`638`	`if (isRunning) {`
`639`		`- if (this.lastBadge instanceof IconBadge && this.lastBadge.icon === spinningLoading) {`
	`639`	`+ if (this.badgeDisposable.value && this.lastBadge instanceof IconBadge && this.lastBadge.icon === spinningLoading) {`
`640`	`640`	`return;`
`641`	`641`	`}`
`642`	`642`
`643`	`643`	`this.lastBadge = new IconBadge(spinningLoading, () => localize('testingRunningBadge', 'Tests are running'));`
`644`	`644`	`} else if (countSummary && this.badgeType !== TestingCountBadge.Off && countSummary[this.badgeType] !== 0) {`
`645`		`- if (this.lastBadge instanceof NumberBadge && this.lastBadge.number === countSummary[this.badgeType]) {`
	`645`	`+ if (this.badgeDisposable.value && this.lastBadge instanceof NumberBadge && this.lastBadge.number === countSummary[this.badgeType]) {`
`646`	`646`	`return;`
`647`	`647`	`}`
`648`	`648`
`649`	`649`	`this.lastBadge = new NumberBadge(countSummary[this.badgeType], num => this.getLocalizedBadgeString(this.badgeType, num));`
`650`	`650`	`} else if (this.crService.isEnabled()) {`
`651`		`- if (this.lastBadge instanceof IconBadge && this.lastBadge.icon === icons.testingContinuousIsOn) {`
	`651`	`+ if (this.badgeDisposable.value && this.lastBadge instanceof IconBadge && this.lastBadge.icon === icons.testingContinuousIsOn) {`
`652`	`652`	`return;`
`653`	`653`	`}`
`654`	`654`