Conversation
…thods Co-authored-by: AArnott <[email protected]>
Co-authored-by: AArnott <[email protected]>
Copilot
AI
changed the title
[WIP]
Fix PartDiscovery.CreatePartsAsync cancellation handling to properly throw OperationCanceledException
Sep 10, 2025
PartDiscovery.CreatePartsAsync should throw OperationCanceledException when its cancellationToken parameter is canceled
AArnott
requested changes
Sep 11, 2025
test/Microsoft.VisualStudio.Composition.Tests/PartDiscoveryTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.VisualStudio.Composition.Tests/PartDiscoveryTests.cs
Outdated
Show resolved
Hide resolved
…plify test setup, and remove unstable test Co-authored-by: AArnott <[email protected]>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot stopped work on behalf of
AArnott due to an error
September 11, 2025 00:55
AArnott
approved these changes
Sep 11, 2025
RyanToth3
approved these changes
Sep 11, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RyanToth3
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new CancellationToken(canceled: true)Changes Made
Original Implementation
CreatePartsAsyncmethodsCode Review Fixes
cancellationTokenparameter from both Task.Run calls inCreateDiscoveryBlockChainandCreateAssemblyDiscoveryBlockChainmethods to prevent hanging the TaskCompletionSourceCancellationTokenSourcewith directCancellationToken token = new(canceled: true)construction for cleaner test codeAll tests are passing and the build succeeds without warnings. The implementation now correctly handles cancellation tokens while avoiding the Task.Run hanging issue identified in code review.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.