Always use InstallPlanAction::package_dir#1604
Merged
BillyONeal merged 1 commit intomicrosoft:mainfrom Mar 7, 2025
Merged
Conversation
... rather than attempting to rederive it several times. This clears the way for several actions that want to install the same package name with different feature sets (in microsoft#802 ) to not step on each others' toes.
JavierMatosD
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... rather than attempting to rederive it several times. This clears the way for several actions that want to install the same package name with different feature sets (in #802 ) to not step on each others' toes.
The remaining callers of
VcpkgPaths::package_dirare all doing so to purge that directory when they will not be building it, and in #802 will need to be taught to purge everything following the disambiguating pattern used.