Closed
Conversation
Contributor
|
/azp run |
Contributor
|
/azp run |
vicroms
reviewed
Jan 22, 2020
Comment on lines
+28
to
+43
| if(CMAKE_HOST_WIN32) | ||
| if(NOT EXISTS ${PYTHON3_DIR}/easy_install${EXECUTABLE_SUFFIX}) | ||
| if(NOT EXISTS ${PYTHON3_DIR}/Scripts/pip${EXECUTABLE_SUFFIX}) | ||
| get_filename_component(PYTHON3_DIR_NAME "${PYTHON3_DIR}" NAME) | ||
| vcpkg_download_distfile(GET_PIP | ||
| URLS "https://bootstrap.pypa.io/3.3/get-pip.py" | ||
| FILENAME "tools/python/${PYTHON3_DIR_NAME}/get-pip.py" | ||
| SHA512 92e68525830bb23955a31cb19ebc3021ef16b6337eab83d5db2961b791283d2867207545faf83635f6027f2f7b7f8fee2c85f2cfd8e8267df25406474571c741 | ||
| ) | ||
| execute_process(COMMAND ${PYTHON3_DIR}/python${EXECUTABLE_SUFFIX} ${GET_PIP}) | ||
| endif() | ||
| execute_process(COMMAND ${PYTHON3_DIR}/Scripts/pip${EXECUTABLE_SUFFIX} install python-gettext --user) | ||
| else() | ||
| execute_process(COMMAND ${PYTHON3_DIR}/easy_install${EXECUTABLE_SUFFIX} python-gettext) | ||
| endif() | ||
| endif() |
Member
There was a problem hiding this comment.
It almost feels like this should be made into a vcpkg helper function.
Contributor
Author
There was a problem hiding this comment.
Yes. Also, this PR was opened too soon. Maybe it’s better if I just close it. I don’t have much time to work on it now, and the required work is a lot before being ready.
Contributor
|
Pinging @cenit for response. Is work still being done for this PR? |
LilyWangL
added
the
category:new-port
Contributor
|
Closing this PR since it seems that no progress is being made. Please reopen if work is still being done. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: #13100