[ignition-cmake0, ignition-math4] Add support for writing ports of Ignition Robotics libraries 🤖#7781
Merged
vicroms merged 3 commits intomicrosoft:masterfrom Sep 3, 2019
Merged
Conversation
Contributor
Author
|
Related downstream issue: j-rivero/vcpkg_ignition#2 . |
traversaro
force-pushed
the
addIgnition
branch
3 times, most recently
from
b647aeb to
5c41ae2
Compare
Modeled after the qt5-modularscript port, this port just contain ignition_modular_library, an helper CMake function to simplify the process of writing port of C++ libraries developed by the Ignition Robotics project ( https://ignitionrobotics.org ).
traversaro
force-pushed
the
addIgnition
branch
from
5c41ae2 to
183061a
Compare
Contributor
Author
|
The ports now compile fine in all the triplets tested by the CI system. Two patches were necessary to permit compilation on |
Member
|
Thanks for the PR! |
vicroms
changed the title
vicroms
changed the title
Contributor
Author
|
Thanks @vicroms ! Just to understand, I now need to add 🤖 to the title of any robotics-related PR? 😄 |
Member
|
The suggested format for titles is "[ports] description" but I thought that the 🤖 would be a nice touch 🤣 |
wow! thanks Silvio! |
traversaro
added a commit
to traversaro/vcpkg
that referenced
this pull request
Sep 9, 2019
Write new ports using the ignition-modularscript port added in microsoft#7781
This was referenced Sep 11, 2019
This was referenced Apr 16, 2020
This was referenced May 9, 2020
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ignition Robotics Libraries ( https://ignitionrobotics.org ) are a set of libraries that are used to develop robotics applications. In particular, they are dependencies for the widely used Gazebo simulator ( http://gazebosim.org ).
In this PR, three ports are added:
ignition-modularscript( 8fb25c1 )ignition-cmake0: A port for the version 0 of the ignition-cmake (https://ignitionrobotics.org/libs/cmake) libraryignition-math4: A port for the version 4 of the ignition-math (https://ignitionrobotics.org/libs/math) libraryAs most ignition libraries follow the same structure and convention, the use of
ignition-modularscriptreduces the process of writing a port of an ignition library to a few lines, unless the library has some particular features, for which custom lines can be added to the portfile.One interesting feature of the ignition libraries is that they different major version of the same library can be installed side-by-side in the same system. For this reason, it is quite natural to create a port for each major supported version, to enable user and downstream project to autonomously select which major version of the library they need. This is the reason why, as a first example of ports, Ignition CMake 0 and Ignition Math 4 are added even if more recent version have been released as well, as they are the version used as dependencies for the latest stable version of the Gazebo robotic simulator.