[vcpkg-script] fix vcpkg bootstrap failing on Musl Arm64#44875
Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom Apr 7, 2025
Merged
[vcpkg-script] fix vcpkg bootstrap failing on Musl Arm64#44875BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal merged 1 commit intomicrosoft:masterfrom
Conversation
Cheney-W
added
the
category:tool-update
Cheney-W
approved these changes
Apr 7, 2025
Cheney-W
added
the
info:needs-maintainer-attention
Cheney-W
changed the title
BillyONeal
approved these changes
Apr 7, 2025
Member
|
Thanks for the fix! |
dg0yt
reviewed
Apr 7, 2025
Contributor
dg0yt
left a comment
dg0yt
left a comment
There was a problem hiding this comment.
I wonder if an autotoolish approach would help in the long term:
case "$ARCH-$UNAME-$CRT" in
arm64-linux-muslc)
...
;;
esacWell, no change requested. Just a note for another PR.
Member
I did want separate variables for 'choose the arm64 one' but the 'red code' already didn't have them so I didn't argue it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #44587, Alpine Arm64 fails to bootstrap vcpkg because it tries to run the glibc binaries on the Musl runtime instead of building from the source. This fixes the issue, making sure the Arm64 binaries are only used on Glibc runtime
Here's the failure:
https://github.com/aminya/setup-cpp/actions/runs/14304315923/job/40084748302#step:6:474