[libdmtx] Correct all errors encountered during of #44636#44657
Merged
vicroms merged 3 commits intomicrosoft:masterfrom Apr 1, 2025
Merged
[libdmtx] Correct all errors encountered during of #44636#44657vicroms merged 3 commits intomicrosoft:masterfrom
vicroms merged 3 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
@dg0yt , this PR will complete the last one. Let me verify all CI tests are ok ,before requesting a new review. |
Contributor
|
You will probably have to remove |
dg0yt
reviewed
Mar 27, 2025
dg0yt
reviewed
Mar 27, 2025
Contributor
dg0yt
left a comment
dg0yt
left a comment
There was a problem hiding this comment.
This can probably be ported to vcpkg_from_github.
Contributor
Author
Let’s try it |
sinfomicien
force-pushed
the
add-libdmtx-port
branch
3 times, most recently
from
366f78c to
f485127
Compare
Contributor
Author
|
Ok @dg0yt , sorry for the mess about my last PR and the beginning of this one. I’m ready for review now. Let me just modify my commit message to say it’a about libdmtx port, and i force push it |
sinfomicien
force-pushed
the
add-libdmtx-port
branch
from
f485127 to
ac5c560
Compare
Thomas1664
reviewed
Mar 27, 2025
sinfomicien
force-pushed
the
add-libdmtx-port
branch
from
ac5c560 to
56cffeb
Compare
…44636) - convert portfile to vcpkg_from_github - Remove unused OPTIONS in vcpkg_cmake_configure - Remove set(VCPKG_POLICY_ALLOW_DEBUG_INCLUDE enabled) from portfile and set a rule to remove ${CURRENT_PACKAGES_DIR}/debug/include instead
sinfomicien
force-pushed
the
add-libdmtx-port
branch
from
56cffeb to
ddcaef0
Compare
WangWeiLin-MV
added
the
category:port-update
…rtfile.cmake Co-authored-by: WangWeiLin-MV <[email protected]>
sinfomicien
force-pushed
the
add-libdmtx-port
branch
from
79c6894 to
c3d00f2
Compare
WangWeiLin-MV
approved these changes
Mar 28, 2025
Contributor
Author
|
Any chance to see this PR merged ? As it correct some mistake in my first PR, merged without review (#44636). Do i need to correct something else ? |
Contributor
WangWeiLin-MV
added
the
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #44636
./vcpkg x-add-version --alland committing the result.