Conversation
|
@m-kuhn Elapsed time to handle qtbase:x64-android: 4.2 min |
This comment was marked as outdated.
This comment was marked as outdated.
c1181b6 to
4a69582
Compare
|
qtbase 6.7 silently overrides toolchain API level 21 with actual API level 23. qtbase also selects |
|
FYI, #42165 changes the Docker base image for Android to 24.04 "Noble". |
Fine, but there is not much impact on Android. Can you add ruby now, as in the linux image? Some ports do (We might also use openjdk from the system packages.) |
|
qtbase and gdal passing now 🎉 |
I suggest to continue with moving vcpkg android CI to this configuration. Probably using new triplets |
bb50a03 to
256a039
Compare
|
Tagging with vm-update so I remember to mint you a new Docker image with the changes here after #42749 |
Oops, I forgot anyway. I blame getting COVID that week :( . Doing patch tuesday stuff for this month now and will look at minting one of these for you this week. |
|
No problem, I probably need a moment to sort the commits. Xmas wasn't enough time for that. What also needs to be discussed:
|
| "glib" CMAKE_REQUIRE_FIND_PACKAGE_GLIB2 | ||
| #"glib" CMAKE_REQUIRE_FIND_PACKAGE_GLIB2 |
There was a problem hiding this comment.
Multiple attempts, success on second one.
(Drive-by fix, based on feature-tests. Complemented by acquiring PKGCONFIG.)
| INPUT_xcb | ||
| INPUT_xkbcommon | ||
| ) | ||
| set(Z_VCPKG_CMAKE_GENERATOR "${Z_VCPKG_CMAKE_GENERATOR}" PARENT_SCOPE) |
There was a problem hiding this comment.
Z_VCPKG_CMAKE_GENERATOR is a cache variable owned by vcpkg-cmake.
|
@JonLiu1993 @LilyWangLL please review. |
|
🙏 thanks @dg0yt ! |
|
Look, it was a simple PR! |
|
Thanks @BillyONeal and team too for improving the base! |
|
I'm not completely sure but the new Edit: okay this patch is fine and actually revealed an issue on my side where |
Reprise from #35845.
Dependencies:
Some feature test warnings which are not specific for Android are left for other PRs.